-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX]l10n_it_vat_statement_communication risolve il problema della regola multi company non funzionante #4353
Open
matteoopenf
wants to merge
1
commit into
OCA:16.0
Choose a base branch
from
matteoopenf:16.0-FIX_IVA_multicompany
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
l10n_it_vat_statement_communication/migrations/16.0.1.1.0/pre-migrate.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import logging | ||
|
||
from openupgradelib import openupgrade | ||
|
||
_logger = logging.getLogger(__name__) | ||
|
||
|
||
@openupgrade.migrate() | ||
def migrate(env, version): | ||
if not version: | ||
return | ||
|
||
rm_old_vat_communication_multi_company_rule(env) | ||
|
||
|
||
def rm_old_vat_communication_multi_company_rule(env): | ||
_logger.info( | ||
"Migration of l10n_it_vat_statement_communication - search for" | ||
" previous multi company rule for 'comunicazione.liquidazione' model" | ||
) | ||
module = "l10n_it_vat_statement_communication" | ||
rule_xml_id = "comunucazione_liquidazione_iva_multi_company" | ||
old_vat_comm_multi_company_rule_ref = env.ref( | ||
f"{module}.{rule_xml_id}", raise_if_not_found=False | ||
) | ||
|
||
if not old_vat_comm_multi_company_rule_ref: | ||
# avoid unlink not existent record | ||
_logger.warning( | ||
"Migration of l10n_it_vat_statement_communication - previous" | ||
" multi company rule for 'comunicazione.liquidazione' model not" | ||
" found" | ||
) | ||
return | ||
|
||
_logger.info( | ||
"Migration of l10n_it_vat_statement_communication - unlink" | ||
" previous multi company rule for 'comunicazione.liquidazione' model" | ||
) | ||
old_vat_comm_multi_company_rule_ref.unlink() | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non credo che ricreare la regola sia safe: l'utente potrebbe averla modificata (in fondo è per quello che è
noupdate
), oppure se fosse collegata ad altri record tramite campi relazionali il collegamento sparirebbe.Normalmente quando una migrazione deve modificare dei record
noupdate
è sufficiente aggiornare il record, in questo caso però non si sta modificando il record ma il suoir.model.data
, quindi la migrazione dovrebbe recuperare l'ir.model.data
e modificarlo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, lo script di migrazione mira a ricreare la regola, che in ambienti migrati resta alla vecchia versione https://github.com/OCA/l10n-italy/blob/12.0/l10n_it_vat_statement_communication/security/security.xml#L9 causando problemi con ambienti multicompany perché il campo usato nella rule potrebbe non corrispondere al valore della proprietà company nell'env che da 14.0 viene usato per molti dei casi; il modificare ir_model_data è solo una correzione ortografica,
comunucazione
non lo trovo correttoOltretutto aggiornare il record della rule modificando il campo domain_force, è lo stesso che farla ricreare; in entrambe i casi se è stata modificata a mano, le modifiche vanno perse; per quanto riguarda il cambiare l'xmlid si può anche tralasciare