Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [FIX] l10n_it_vat_statement_communication: fix file doctype declaration #4357

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[16.0] [FIX] l10n_it_vat_statement_communication: fix file doctype declaration #4357

merged 1 commit into from
Sep 9, 2024

Conversation

patrickt-oforce
Copy link
Contributor

@patrickt-oforce patrickt-oforce commented Sep 5, 2024 •
edited
Loading

Forward port of #4148 and #4317

@patrickt-oforce patrickt-oforce mentioned this pull request Sep 5, 2024
Closed
2 tasks
matteoopenf
matteoopenf approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@matteoopenf matteoopenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirAionTech SirAionTech linked an issue Sep 5, 2024 that may be closed by this pull request
[l10n_it_vat_statement_communication] problema encoding file nome file e zeri nell'esportazione xml #4149
Closed
2 tasks
MaurizioPellegrinet
MaurizioPellegrinet approved these changes Sep 5, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

@tafaRU
Copy link
Member

tafaRU commented Sep 5, 2024

@patrickt-oforce come mai ci sono due commit? Non dovrebbe trattarsi semplicemente del FW port di #4148?

@matteoopenf
Copy link
Contributor

@patrickt-oforce come mai ci sono due commit? Non dovrebbe trattarsi semplicemente del FW port di #4148?

Lo feci con due pr ecco perché

@matteoopenf
Copy link
Contributor

@patrickt-oforce come mai ci sono due commit? Non dovrebbe trattarsi semplicemente del FW port di #4148?

#4317 questa è la seconda pr non era traccia nella issue

@patrickt-oforce
Copy link
Contributor Author

@patrickt-oforce come mai ci sono due commit? Non dovrebbe trattarsi semplicemente del FW port di #4148?

Buondì @tafaRU se volete li schiaccio in uno solo; io ho fatto solo cherry-pick dalla #4148 e #4317

@tafaRU
Copy link
Member

tafaRU commented Sep 9, 2024

se volete li schiaccio in uno solo

sì grazie, mentre lo fai ricordati di modificare il messaggio del commit rispettando le indicazioni riportate in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message.

@patrickt-oforce patrickt-oforce force-pushed the 16.0-FIX-l10n_it_vat_statement_communication branch from 091ef4f to ce09455 Compare September 9, 2024 09:30
@patrickt-oforce
Copy link
Contributor Author

se volete li schiaccio in uno solo

sì grazie, mentre lo fai ricordati di modificare il messaggio del commit rispettando le indicazioni riportate in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message.

Commit uniti

@tafaRU
Copy link
Member

tafaRU commented Sep 9, 2024

@patrickt-oforce

nel commit message leggo:

Fix xml doctype declaration adding charset encoding as utf-8

ma se non erro è già presente, non lo stai aggiungendo con questa PR --> puoi modificare il messaggio?

Grazie.

@matteoopenf @patrickt-oforce
[FIX]l10n_it_vat_statement_communication: fix file export
6217e56 
Avoid to output value at zero according to AdE specification

In exported xml file fix the character encoding value in doctype
declaration
@patrickt-oforce patrickt-oforce force-pushed the 16.0-FIX-l10n_it_vat_statement_communication branch from ce09455 to 6217e56 Compare September 9, 2024 10:45
@patrickt-oforce
Copy link
Contributor Author

@patrickt-oforce

nel commit message leggo:

Fix xml doctype declaration adding charset encoding as utf-8

ma se non erro è già presente, non lo stai aggiungendo con questa PR --> puoi modificare il messaggio?

Grazie.

Aggiornato

@tafaRU
Copy link
Member

tafaRU commented Sep 9, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-4357-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ebd4d4c into OCA:16.0 Sep 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fb77e79. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU approved these changes

@matteoopenf matteoopenf matteoopenf approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[l10n_it_vat_statement_communication] problema encoding file nome file e zeri nell'esportazione xml
5 participants
@patrickt-oforce @tafaRU @matteoopenf @OCA-git-bot @MaurizioPellegrinet