-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] Migration to 14.0 l10n_it_fatturapa_out_fd #4386
base: 14.0
Are you sure you want to change the base?
Conversation
499801c
to
e34dc54
Compare
e34dc54
to
bf0f225
Compare
@TheMule71 pronto per la review! |
Ho notato che il numero della fattura, anche se assegnato, viene impostato in automatico ad un numero diverso (con la sequenza 'per mese' di default), cosa che non si nota nei vari test dove non si fa un controllo completo dell'xml.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grazie della PR!
<ns1:FatturaElettronica xmlns:ns1="http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2" versione="FPR12"> | ||
<ns1:FatturaElettronica | ||
xmlns:ns1="http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2" | ||
versione="FPR12" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cambiamenti fatti in automatico da pre-commit
andrebbero lasciati in un commit a sé precedente la migrazione, come indicato in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0:
$ git clone https://github.com/OCA/$REPO -b 14.0
$ git checkout -b 14.0-mig-$MODULE origin/14.0
$ git format-patch --keep-subject --stdout origin/14.0..origin/13.0 -- $MODULE | git am -3 --keep
$ pre-commit run -a # to run black, isort and prettier (ignore pylint errors at this stage)
$ git add -A
$ git commit -m "[IMP] $MODULE: black, isort, prettier" --no-verify # it is important to do all formatting in one commit the first time
riesci a correggere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dovrei aver fatto
l10n_it_fatturapa_out_fd/README.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puoi schiacciare i commit fatti dai bot come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests?
A occhio della storia di 12.0
dovrebbe rimanere solo il commit ADD e un commit di traduzione, invece dei 5 che ci sono adesso
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fatto
@api.model | ||
def getTemplateValues(self, template_values): | ||
template_values = super().getTemplateValues(template_values) | ||
template_values.update({"get_importo": self.get_importo}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Così facendo sovrascrivi la funzione get_importo
che c'è già in template_values
:
"get_importo": get_importo, |
Potresti invece mantenere l'ereditarietà? Ad esempio puoi vedere come è stato fatto per
get_importo_totale
: l10n-italy/l10n_it_fatturapa_out/wizard/efattura.py
Lines 186 to 189 in 919ac3f
def get_importo_totale(invoice): | |
# wrapper to a method in wizard (for better overriding) | |
wiz = self.env["wizard.export.fatturapa"] | |
return wiz.getImportoTotale(invoice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dovrei aver fatto
invoice_form = Form( | ||
self.env["account.move"].with_context(default_move_type="out_invoice") | ||
) | ||
invoice_form.name = "INV/2020/01/0001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ho notato che il numero della fattura, anche se assegnato, viene impostato in automatico ad un numero diverso (con la sequenza 'per mese' di default), cosa che non si nota nei vari test dove non si fa un controllo completo dell'xml. Questa assegnazione in pratica è ignorata:
move_form.name = "INV/2016/0013"
Se come scrivi viene ignorata, si può rimuovere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fatto
9fafba4
to
420f135
Compare
dbbf7a4
to
2418018
Compare
e5e12ea
to
100ea0f
Compare
@SirAionTech dovrei aver fatto tutto |
No description provided.