Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLA Bot should check also on deactivated partners #170

Closed
pedrobaeza opened this issue Feb 18, 2022 · 9 comments
Closed

CLA Bot should check also on deactivated partners #170

pedrobaeza opened this issue Feb 18, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@pedrobaeza
Copy link
Member

If not, ex-exployees with their proper CLA are shown as missing when doing migrations.

@sbidoul
Copy link
Member

sbidoul commented Apr 3, 2022

Duplicate of #209 and wrong project.

@sbidoul sbidoul closed this as completed Apr 3, 2022
@gurneyalex
Copy link
Member

well actually not the wrong project @sbidoul : https://github.com/OCA/oca-github-bot/tree/clabot ;)

@sbidoul
Copy link
Member

sbidoul commented Apr 6, 2022

@gurneyalex yes, sure I remember that PR. But do we want to finish that one, or rather keep the existing bot on life support and invest time in setting up a paperless CLA process ?

@gurneyalex
Copy link
Member

this is actually the branch where the source code of the legacty runbot is living. There was another PR to migrate it to the gitbot, but we decided against it in the end.

I'm all in favor of setting up a paperless CLA process ;)

@gurneyalex
Copy link
Member

(and killing the legacy runbot)

@sbidoul
Copy link
Member

sbidoul commented Apr 6, 2022

this is actually the branch where the source code of the legacty runbot is living

Oh, ah, TIL. Good to know. I was mixing with https://github.com/OCA/maintainer-tools/blob/master/tools/github_clabot_hook.py.

@pedrobaeza
Copy link
Member Author

And meanwhile can we include deactivated partners? It shouldn't be too hard.

@gurneyalex
Copy link
Member

@pedrobaeza yes I just did so

@pedrobaeza
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants