You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Module script is converted to instance of class
* It is easy to convert, only need move the current content of script to __init__ class
* All script have the run base function that operates with protected properties _TEXT_REPLACES, ERRORS, ETC. `def run(self, module_path, manifest_path, module_name, migration_steps, directory_path, commit_enabled)`
* Also have `def process_file(self, root, filename, extension, file_renames, directory_path, commit_enabled)` to process file one by one
* If a script fail you can know so easy. Only need review the stack trace.
* On this refactoring you could delete global functions. Only you need inherit run method and overwrite it
* I have maintain global_funtions
Since I intend to continue working on the tool and I prefer that the author give me his opinion, I am going to keep a branch in my fork and I will continue doing PR in the master of this repository. I await the code review. If they give me OK, when the time comes I will do a PR with the refactoring
The text was updated successfully, but these errors were encountered:
Can someone review this refactoring? On my fork, in the flachica_features branch, I made some changes that I think may be interesting.
Refactoring is totally optional but I found it useful. Also, on my branch I included those commits that the author could not review due to work overload
In this PR I propossed the refactoring to
Since I intend to continue working on the tool and I prefer that the author give me his opinion, I am going to keep a branch in my fork and I will continue doing PR in the master of this repository. I await the code review. If they give me OK, when the time comes I will do a PR with the refactoring
The text was updated successfully, but these errors were encountered: