From 029be633c534b2cf7de12f30e4d4b00e32853cfb Mon Sep 17 00:00:00 2001
From: Sibert Aerts <sibert.aerts@gmail.com>
Date: Wed, 6 Nov 2024 09:57:45 +0100
Subject: [PATCH] [FIX] sale_layout_category_hide_detail: Improve
 interoperability, hide discounted price too

---
 .../views/invoice_report_templates.xml              |  6 +++---
 .../views/sale_order_report_templates.xml           |  8 ++++----
 .../views/sale_portal_templates.xml                 | 13 ++++++++++---
 3 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/sale_layout_category_hide_detail/views/invoice_report_templates.xml b/sale_layout_category_hide_detail/views/invoice_report_templates.xml
index bcee49db..08c14e15 100644
--- a/sale_layout_category_hide_detail/views/invoice_report_templates.xml
+++ b/sale_layout_category_hide_detail/views/invoice_report_templates.xml
@@ -66,14 +66,14 @@
     <xpath expr="//span[@t-field='line.price_unit']" position="attributes">
         <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
       </xpath>
       <xpath expr="//span[@t-field='line.price_subtotal']" position="attributes">
         <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
       </xpath>
@@ -83,7 +83,7 @@
         >
         <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
       </xpath>
diff --git a/sale_layout_category_hide_detail/views/sale_order_report_templates.xml b/sale_layout_category_hide_detail/views/sale_order_report_templates.xml
index 80e7c84d..d9c0d20d 100644
--- a/sale_layout_category_hide_detail/views/sale_order_report_templates.xml
+++ b/sale_layout_category_hide_detail/views/sale_order_report_templates.xml
@@ -78,28 +78,28 @@
     <xpath expr="//td[@name='td_priceunit']/span" position="attributes">
       <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
     </xpath>
     <xpath expr="//td[@name='td_taxes']/span" position="attributes">
       <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
     </xpath>
     <xpath expr="//td[@name='td_subtotal']/span" position="attributes">
       <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
     </xpath>
     <xpath expr="//td[@t-if='display_discount']/span" position="attributes">
       <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
     </xpath>
diff --git a/sale_layout_category_hide_detail/views/sale_portal_templates.xml b/sale_layout_category_hide_detail/views/sale_portal_templates.xml
index b5344d8c..4730db46 100644
--- a/sale_layout_category_hide_detail/views/sale_portal_templates.xml
+++ b/sale_layout_category_hide_detail/views/sale_portal_templates.xml
@@ -82,14 +82,21 @@
     <xpath expr="//div[@t-field='line.price_unit']" position="attributes">
         <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
+                separator=" and "
+            />
+      </xpath>
+    <xpath expr="//t[contains(@t-out, 'line.price_unit')]" position="attributes">
+        <attribute
+                name="t-if"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
       </xpath>
       <xpath expr="//span[@t-field='line.price_subtotal']" position="attributes">
         <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
       </xpath>
@@ -99,7 +106,7 @@
         >
         <attribute
                 name="t-if"
-                add="not current_section or current_section.show_line_amount"
+                add="(not current_section or current_section.show_line_amount)"
                 separator=" and "
             />
       </xpath>