Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] base_multicompany_reporting_currency: Migration to 16.0 #261

Open
wants to merge 9 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] base_multicompany_reporting_currency: Migration to 16.0 #261

wants to merge 9 commits into from

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Apr 4, 2024 •
edited
Loading

Module migrated to version 16.0

cc https://github.com/APSL 153695

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

Issue #174

@peluko00 peluko00 mentioned this pull request Apr 4, 2024
Open
12 tasks
mpascuall
mpascuall approved these changes Apr 11, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly, checked in runboat

@OCA-git-bot
Copy link
Contributor

Sorry @peluko00 you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@vvrossem
Copy link

@yankinmax could you please review?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@vvrossem vvrossem mentioned this pull request Apr 15, 2024
Closed
@peluko00 peluko00 mentioned this pull request Apr 22, 2024
Open
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@peluko00
Copy link
Author

@yankinmax Seems it's ready to merge

@peluko00 peluko00 force-pushed the 16.0-mig-base_multicompany_reporting_currency branch from 19bf29f to f41bf34 Compare August 19, 2024 06:47
@peluko00 peluko00 force-pushed the 16.0-mig-base_multicompany_reporting_currency branch from f41bf34 to 95d7894 Compare August 19, 2024 06:48
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvrossem vvrossem vvrossem approved these changes

@yankinmax yankinmax yankinmax approved these changes

@mpascuall mpascuall mpascuall approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peluko00 @OCA-git-bot @vvrossem @yankinmax @mpascuall @jabelchi