Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sale_exception: sale.order _order property #3495

Closed
rousseldenis opened this issue Dec 16, 2024 · 2 comments · Fixed by #3503
Closed

sale_exception: sale.order _order property #3495

rousseldenis opened this issue Dec 16, 2024 · 2 comments · Fixed by #3503
Labels
bug

Comments

@rousseldenis
Copy link
Contributor

In 8e7b446#diff-dc48d49fa585bc657a22c490084f3d40dedddc12b8d973a22fcafe1471f73eb1R69

The main exception has been put in _order attribute.

The thing is changing default model _order can lead to misbehaviors for module that are not aware of it.

IMHO, this should be avoided.

@sebastienbeau What do you think ?
@rousseldenis
Copy link
Contributor Author

@rvalyi @renatonlima @guewen @yvaucher @simahawk @hparfr @florian-dacosta @ivantodorovich as you are conributors of this module.

I will revert that order change as it breaks standard behavior.

This implies a change in order and order lines sort order.

I have the idea to maybe add a dedicated action to get that behavior back but on view only.

@hparfr
Copy link

hparfr commented Dec 18, 2024

Agree.

In fact, having the errors first is not always desired.

@rousseldenis rousseldenis linked a pull request Dec 18, 2024 that will close this issue
[FIX] sale_exception: Don't order by main exception #3503
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] sale_exception: Don't order by main exception acsone/sale-workflow
2 participants
@hparfr @rousseldenis