Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try moving Area A checks and handling of missing periods from the parser into the scanner #91

Open
nberth opened this issue Feb 28, 2023 · 1 comment

Comments

@nberth
Copy link
Contributor

nberth commented Feb 28, 2023

For sure the current approach is incomplete and does not cover many cases as you noticed (I think I mentioned this limitation a while ago, but maybe I was not explaining this clearly enough…).

I think working that around properly and in full generality is very tricky with the current pull parser. One approach may be to switch to a push parser whose state may be checked in the scanner when issuing tokens; I tried this at some point, but hit some other problems as this messes up parts of the state that is shared between the scanner and the parser. Going the ad hoc route and adding more manual checks in some places could work, but only in the short term.

Note that moving area A detection to the scanner may require moving the detection of missing periods there as well…

Originally posted by @nberth in #35 (comment)

@GitMensch
Copy link
Collaborator

GitMensch commented Jun 9, 2023

For GC 3.2 the current approach will be kept, so I'm adding a bunch of manual checks that I've found missing.
Testing other approaches that may be shipped later sounds like a good thing to do (but seems like a bigger task).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants