Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a different callout per colour #355

Open
chee opened this issue May 11, 2024 · 5 comments
Open

Allow a different callout per colour #355

chee opened this issue May 11, 2024 · 5 comments

Comments

@chee
Copy link

chee commented May 11, 2024

On the new colour kobo ereaders there's an extra column in the Bookmark (Color) which is an int indicating the highlight colour of the highlight:

  • 0 yellow
  • 1 pink
  • 2 blue
  • 3 green

it would be great to be able to set different callouts for each of these in the plugin options!

great plugin , thank u

@OGKevin
Copy link
Owner

OGKevin commented May 17, 2024

Do you mind pasting your software version of your ereader?
I'm wondering if this column has been added to all models or only the ones that support color.

@esthor
Copy link

esthor commented Jun 25, 2024

I have the Libra Colour, my db has the Color column, and the device is running version 4.39.22861.

This would be an awesome feature, since I use the colors extensively to organize highlights (e.g. 'good quotes' vs. 'further reading'). This was literally the first feature I was looking for when I started using this plugin 15 minutes ago. 😄

I'd love to help if I can. Besides updating the types, would it be sufficient to add it to the SELECT and the .push() in this method in repository.ts?

@OGKevin
Copy link
Owner

OGKevin commented Jun 26, 2024

Yes, and then actually using the new type to change the callout color.
But we still need to verify if all models, even the ones who don't support colour, have this column.

Or write some code that checks if this column exists, and if so, queries it from the DB.

@esthor
Copy link

esthor commented Jul 3, 2024

That makes sense to me. I'd imagine it would not exist on older DB versions and some users may be on older versions, so the column check safety would seem necessary. What do you think?

@OGKevin
Copy link
Owner

OGKevin commented Jul 8, 2024

Yea, adding the column check just in case would be indeed a good idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants