-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a different callout per colour #355
Comments
Do you mind pasting your software version of your ereader? |
I have the Libra Colour, my db has the Color column, and the device is running version 4.39.22861. This would be an awesome feature, since I use the colors extensively to organize highlights (e.g. 'good quotes' vs. 'further reading'). This was literally the first feature I was looking for when I started using this plugin 15 minutes ago. 😄 I'd love to help if I can. Besides updating the types, would it be sufficient to add it to the SELECT and the .push() in this method in repository.ts? |
Yes, and then actually using the new type to change the callout color. Or write some code that checks if this column exists, and if so, queries it from the DB. |
That makes sense to me. I'd imagine it would not exist on older DB versions and some users may be on older versions, so the column check safety would seem necessary. What do you think? |
Yea, adding the column check just in case would be indeed a good idea :) |
On the new colour kobo ereaders there's an extra column in the Bookmark (
Color
) which is an int indicating the highlight colour of the highlight:0
yellow1
pink2
blue3
greenit would be great to be able to set different callouts for each of these in the plugin options!
great plugin , thank u
The text was updated successfully, but these errors were encountered: