Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the situation when Condition Era is not built from Condition occurrence where condition_concept_id =0 #493

Open
dimshitc opened this issue Oct 6, 2023 · 2 comments
Assignees
Labels
check bug/enhancement DQ check SQL logic has a bug or needs refinement Good first issue

Comments

@dimshitc
Copy link
Collaborator

dimshitc commented Oct 6, 2023

Please edit the measureConditionEraCompleteness checl

The number and Percent of persons that does not have condition_era built successfully for all persons in condition_occurrence.
It should omit Condition records where condition_concept_id = 0. In this case it's OK, that era is not built

@katy-sadowski
Copy link
Collaborator

Agree, good catch. People whose only CO rows have 0 concept_id, and people who have no conditions at all (already excluded from the check), should not be expected to have condition eras. And we'll flag the missed standard concept mapping in another check.

@katy-sadowski katy-sadowski added the check bug/enhancement DQ check SQL logic has a bug or needs refinement label Oct 7, 2023
@dimshitc dimshitc self-assigned this Nov 30, 2023
@MaximMoinat
Copy link
Collaborator

MaximMoinat commented Feb 5, 2024

Note that the default condition era derivation script does NOT filter for condition_concept_id = 0:
https://ohdsi.github.io/CommonDataModel/sqlScripts.html#Condition_Eras
Edit: I think this might be an error with the default condition era script. Making eras for conditions with concept 0 does not make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check bug/enhancement DQ check SQL logic has a bug or needs refinement Good first issue
Projects
None yet
Development

No branches or pull requests

3 participants