Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check on concept_id length #515

Open
clairblacketer opened this issue Dec 8, 2023 · 1 comment
Open

Add a check on concept_id length #515

clairblacketer opened this issue Dec 8, 2023 · 1 comment
Labels
new check New DQ check to be added

Comments

@clairblacketer
Copy link
Collaborator

Many database owners create their own custom concepts in the 2B+ range to represent some local values. We recently ran into an issue trying to use these concepts in ATLAS. Come to find out these concepts need to stay under 2,147,483,648 to be viable in the standard tools. It would be good to add a check for this.

@katy-sadowski katy-sadowski added the new check New DQ check to be added label Dec 9, 2023
@katy-sadowski
Copy link
Collaborator

let's get this added (ghost of Clair past agrees - #248 😛 ). i think the best way to implement this will be the overhaul of cdmDatatype to truly check column types against the CDM specs. (this value and above won't be able to exist in a 4 byte integer col)

if we want to add a short term patch we could also require integer cols (the only ones checked right now in cdmDatatype anyways) to be <2147483648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new check New DQ check to be added
Projects
None yet
Development

No branches or pull requests

2 participants