Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRISP SRV17(BA) - compliance check #1732

Open
vishal-ondc opened this issue Oct 4, 2024 · 0 comments
Open

CRISP SRV17(BA) - compliance check #1732

vishal-ondc opened this issue Oct 4, 2024 · 0 comments

Comments

@vishal-ondc
Copy link
Collaborator

@CRISP-SWD-IT

Flow- 1(Catalog Pull)

Search

  • Message>intent>time>range>end- This key is not allowed.

On_Search

  • Message>catalog>providers - Same provider sending two times
  • Message>catalog>providers>descriptor>additional_desc- Its optional, if doesn’t have data, no need to send it
  • Message>catalog>providers>descriptor>code -Its optional, if doesn’t have data, no need to send it
  • Message>catalog>providers>descriptor>short_desc -Its mandatory, so send valid data
  • Message>catalog>providers>descriptor>long_desc -Its mandatory, so send valid data
  • Message>catalog>providers>rating - If no rating available then no need to send as its only allowed value is 1.0-5.0
  • Message>catalog>providers>locations>address - "CRISP ,,,Bhopal,Madhya Pradesh", Just for improvement, address should be valid and should not have unnecessary comma
  • Message>catalog>providers>items>descriptor>long_desc - Its mandatory, so send valid data
  • Message>catalog>providers>items>descriptor>media - Its optional, if doesn’t have data, no need to send it
  • Message>catalog>providers>items>cancellation_terms - Hope you have the cancellation terms on status basis and have implemented accordingly
  • Message>catalog>providers>items>tags>SERVICE_INFORMATION - Added this tags without any data
  • Message>catalog>providers>items>tags>EQUIPMENT_ATTRIBUTES>RUNNING_HOURS - Its optional, if doesn’t have data, no need to send it
  • Message>catalog>providers>items>tags>EQUIPMENT_ATTRIBUTES>MISCELLANEOUS_INFO - Its optional, if doesn’t have data, no need to send it
  • Message>catalog>providers>items>tags>CHECKLIST_DOCUMENTS - Its attribute have NA values, its not allowed
  • Message>catalog>providers>items>time - its either be range based on frequency based time so if you defined the range then range and days are mandatory otherwise schedule frequency and time array
  • Message>catalog>providers>items>time>days - It should have valid data like “1,2,3,4,5,6,7”
  • Message>catalog>providers>items>time>frequency - its can’t be empty in case you have selected multiple time in times array
  • Message>catalog>providers>items>time>times - It should have valid array of date string

Flow 2 ( Order Flow )

Select

  • Message>order>items - Please select more then 1 item
  • Message>order>fulfillments>stops>location>gps - its not valid for area_code, make sure you are setting it correctly

###On_Select

  • Message>order>items>time - its not allowed in this call
  • Message>order>fulfillments>id - its required
  • Message>order>quote>breakup>pickup_charge>price>value - It should be valid (suggestion - 00 is not a valid data)

Init

  • Message>order>billing>tax_id - it should be valid data
  • Message>order>fulfillments>id - its required
  • Message>order>fulfillments>type - It should be valid, End is not allowed
  • Message>order>fulfillments>stops>location>address - its required and should have valid data
  • Message>order>fulfillments>stops>location>city>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>state>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>contact>phone - its required and should have valid data

on_init

  • Message>order>items>tags>CHECKLIST_DOCUMENTS - Its attribute have NA values, its not allowed
  • Message>order>items>tags>INSURANCE - Its attribute have dummy data
  • Message>order>billing>tax_id - it should be valid data
  • Message>order>fulfillments>stops>location>address - its required and should have valid data
  • Message>order>fulfillments>stops>location>city>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>state>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>contact>phone - its required and should have valid data
  • Message>order>quote>breakup>pickup_charge>price>value - It should be valid (suggestion - 00 is not a valid data)

confirm

  • Message>order>provider>locations - missing
  • Message>order>items>tags>CHECKLIST_DOCUMENTS - Its attribute have NA values, its not allowed
  • Message>order>items>tags>INSURANCE - Its attribute have dummy data
  • Message>order>billing>tax_id - it should be valid data
  • Message>order>billing>email - missing
  • Message>order>fulfillments>stops>location>address - its required and should have valid data
  • Message>order>fulfillments>stops>location>city>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>state>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>contact>phone - its required and should have valid data
  • Message>order>quote>breakup>pickup_charge>price>value - It should be valid (suggestion - 00 is not a valid data)
  • Message>order>payments>params>bank_account_number - missing value
  • Message>order>payments>params>virtual_payment_address - missing value
  • Message>order>payments>tags - Missing

on_confirm

  • Message>order>provider>locations - missing
  • Message>order>items>tags>CHECKLIST_DOCUMENTS - Its attribute have NA values, its not allowed
  • Message>order>items>tags>INSURANCE - Its attribute have dummy data
  • Message>order>billing>tax_id - it should be valid data
  • Message>order>billing>email - missing
  • Message>order>fulfillments>stops>location>address - its required and should have valid data
  • Message>order>fulfillments>stops>location>city>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>state>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>contact>phone - its required and should have valid data
  • Message>order>quote>breakup>pickup_charge>price>value - It should be valid (suggestion - 00 is not a valid data)
  • Message>order>payments>params>bank_account_number - missing value
  • Message>order>payments>params>virtual_payment_address - missing value
  • Message>order>payments>tags - Missing

on_status (AT_LOCATION, completed, In transit)

  • Message>order>provider>locations - missing
  • Message>order>billing>tax_id - it should be valid data
  • Message>order>billing>email - missing
  • Message>order>created_at - unsupported format, it should be in ISO format
  • Message>order>documents>url - It should have valid url
  • Message>order>fulfillments>stops>location>address - its required and should have valid data
  • Message>order>fulfillments>stops>location>city>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>state>name - its required and should have valid data
  • Message>order>fulfillments>stops>location>contact>phone - its required and should have valid data
  • Message>order>quote>breakup>pickup_charge>price>value - It should be valid (suggestion - 00 is not a valid data)
  • Message>order>payments>params>bank_account_number - missing value
  • Message>order>payments>params>virtual_payment_address - missing value
  • Message>order>payments>tags - Missing

Flow 3 ( No Equipment Available )

  • All the issues same as flow 2
  • on_select Message>order>items>quantity>selected>measure>value - it should have valid value, but sent “24.0 “ (white space)
  • on_select Message>order>items>id - need to select new item but you sent the same with same quantity and time range

Flow 4 ( Availability Changes during the transaction Journey )

  • All the issues same as flow 2

Flow 5 ( Buyer cancel the Placed Order )

  • All the issues same as flow 2
  • Cancel - Message>cancellation_reason_id - id should be 01
  • on_cancel - same data is as above specified

Flow 6 (Requisite documents not available during equipment delivery pickup)

  • All the issues same as flow 2

Flow 7 (Seller partially cancel the placed Order)

  • Missing flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant