Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of simplecov branch coverage #721

Open
ShockwaveNN opened this issue Jan 11, 2021 · 1 comment
Open

Add support of simplecov branch coverage #721

ShockwaveNN opened this issue Jan 11, 2021 · 1 comment
Milestone

Comments

@ShockwaveNN
Copy link
Collaborator

No description provided.

@ShockwaveNN
Copy link
Collaborator Author

Seems this is rather difficult task

Branch coverage do not like construction like this:

      node.xpath('*').each do |preset_geometry_child|
        case preset_geometry_child.name
        when 'pctWidth'
          @width = PictureDimension.new(parent: self).parse(preset_geometry_child)
        end
      end

I've tried to add else case with something like this:

      node.xpath('*').each do |node_child|
        case node_child.name
        when 'pctWidth'
          @width = PictureDimension.new(parent: self).parse(node_child)
        else
          Parser.logger.info("Unsupported child node #{node_child.name}")
        end
      end

But this do not solve problem, since there is no files who get in else branch any way, so not only branch coverage is not changed, but default coverage is decreased

@ShockwaveNN ShockwaveNN added this to the p2 milestone Dec 23, 2021
@ShockwaveNN ShockwaveNN removed their assignment Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant