From 5a52ac9127785bc258f20b9232e5fe43ba2e28ce Mon Sep 17 00:00:00 2001
From: danilapog <danil.titarenko@onlyoffice.com>
Date: Thu, 13 Jul 2023 11:47:00 +0300
Subject: [PATCH] Add check deprecated recources

Deprecated resources in manifests are checked by submitting manifests to k8s api with --dry-run command. This requires that the Kubernetes cluster must be deployed. In this case minikube use always the latest version from official gh k8s repo
---
 .github/workflows/lint.yaml | 39 +++++++++++++++++++++++++++++--------
 1 file changed, 31 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
index 5fefcb173..92225d75d 100644
--- a/.github/workflows/lint.yaml
+++ b/.github/workflows/lint.yaml
@@ -48,6 +48,14 @@ jobs:
             KUBE_RELEASE=$(curl -L -H "Accept: aplication/vnd.github+json" https://api.github.com/repos/kubernetes/kubernetes/releases/latest)
             echo "kube-latest=$(echo ${KUBE_RELEASE} | jq -r '.tag_name')" >> "$GITHUB_ENV"
 
+      - name: start minikube
+        id: minikube
+        uses: medyagh/setup-minikube@latest
+        with:
+          cpus: 2
+          memory: 6500m
+          kubernetes-version: ${{ env.kube-latest }}
+
       - name: Setup pluto
         run: |
             wget https://github.com/FairwindsOps/pluto/releases/download/v${PLUTO_VER}/pluto_${PLUTO_VER}_linux_amd64.tar.gz
@@ -78,8 +86,8 @@ jobs:
                                          --target-versions k8s=${{ env.kube-latest }} \
                                          -ojson)
 
-           DEPRECATED=$(echo ${RESULT_JSON} | jq -r '.items[] | select ( .deprecated==true and .removed==false ).name' | paste -sd, || true)
-           REMOVED=$(echo ${RESULT_JSON} | jq -r '.items[] | select ( .removed==true ).name' | paste -sd, || true)
+           DEPRECATED_API=$(echo ${RESULT_JSON} | jq -r '.items[] | select ( .deprecated==true and .removed==false ).name' | paste -sd, || true)
+           REMOVED_API=$(echo ${RESULT_JSON} | jq -r '.items[] | select ( .removed==true ).name' | paste -sd, || true)
 
            helm template -f values.yaml . ${KEYS} \
                         | pluto detect - --ignore-deprecations \
@@ -87,16 +95,31 @@ jobs:
                                          --target-versions k8s=${{ env.kube-latest }} \
                                          -omarkdown
 
-           if [ "${REMOVED}" != "" ]; then
+           #############################################
+           ## Check deprecated recources in manifests ##
+           #############################################
+
+           helm template -f ./values.yaml . ${KEYS} > deprecate-check.yaml
+           kubectl --dry-run=server --warnings-as-errors apply -f ./deprecate-check.yaml >out.log 2>&1 || true
+           DEPRECATED_REC=$(awk '/Warning/{print}' out.log)
+
+           if [ "${DEPRECATED_REC}" != "" ]; then
+              echo "::error title=Warning message from k8s api detected,line=1,col=5,endColumn=7::"${DEPRECATED_REC}""
+              EXIT_CODE=1
+           fi
+
+           if [ "${REMOVED_API}" != "" ]; then
               echo "::error title=Removed api detected!,line=1,col=5,endColumn=7::\
-              Api  for this resources: ${REMOVED} will be removed. Target version: ${{ env.kube-latest }} \
+              Api  for this resources: ${REMOVED_API} will be removed. Target version: ${{ env.kube-latest }} \
               Please check log and get more information"
-              exit 1
+              EXIT_CODE=1
            fi
 
-           if [ "${DEPRECATED}" != "" ]; then
+           if [ "${DEPRECATED_API}" != "" ]; then
               echo "::warning title=Deprecated api detected,line=1,col=5,endColumn=7::\
-              Api for this recources: ${DEPRECATED} will be deprecated. Target version: ${{ env.kube-latest }} \
+              Api for this recources: ${DEPRECATED_API} will be deprecated. Target version: ${{ env.kube-latest }} \
               Please check log and get move information"
-              exit 0
+              EXIT_CODE=1
            fi
+
+           exit ${EXIT_CODE}