Button

[bameyrick]

Use this place to discuss the button component in the ONS Design System

[jrbarnes9]

Issue #351 resolved

[jrbarnes9]

Issue #364 resolved

[jrbarnes9]

Issue #396 resolved

[jrbarnes9]

Issue #396 resolved

[jrbarnes9]

Issue #500 resolved

[jrbarnes9]

Issue #507 resolved

[jrbarnes9]

#740 resolved

[jrbarnes9]

#739 resolved

[trevorsaint]

I think we need a button that looks like a link. I also would expect .btn--link to be a modifier to do exactly that.

However we are using the modifier .btn--link to make links look like buttons. Do we really need to do this? Can’t we just assume that if an <a>, <button> has a class of .btn it will look like a button.

I do feel this is a much better approach, and we can use the modifier to have a <button> that looks like a link.

GDS do it this way and it does make more sense.
https://design-system.service.gov.uk/components/button/

[jrbarnes9]

#761 raised

[jrbarnes9]

Do we need a loader and timer button? This should probably be default behaviour for a submit button, as you'd never want user to double-click it, and you'd always need to show user feedback (spinner) if the process takes longer than a certain delay.

[jrbarnes9]

rmccar on 30 Jul 2020:
It is linked to setting the button type to be a submit button but I suppose we could change the logic a little bit so that it doesn't allow you to have a submit button without setting a submit type?

[jrbarnes9]

Issue #1279 resolved

[jrbarnes9]

#1400 resolved

[jrbarnes9]

#1531 raised

[jrbarnes9]

#1656 resolved

[jrbarnes9]

#1655 resolved

[jrbarnes9]

Disabled button should use aria-disabled attribute so screen readers can discover it's disabled state

https://a11y-101.com/development/aria-disabled

[armstrongb]

Also worth a read. https://css-tricks.com/making-disabled-buttons-more-inclusive/

[jrbarnes9]

Print button icon not from brand guidelines: https://www.notion.so/ons-design/Iconography-87521a48ce4d4c2b85b71fe455a7ca5e?p=ae78b8e94e84458087210cfd444f2707

Should be using:

[jrbarnes9]

Raised #2085

[jrbarnes9]

Raised #2436

[jrbarnes9]

Change buttonContext macro option description as it references an example that no longer exists

[jrbarnes9]

Raised #2512

[jrbarnes9]

variants missing from Button macro options documentation

[jrbarnes9]

Raised #2582

[Al-Davies]

UR Findings
users clearly seeing these CTA buttons - on census home page (start census), within eq (continue, save and signout) - submit census > no indication of any confusion with this
participants clear they need to click this button in order to submit the form they have completed. Until they click this they know the information won't get sent.
8.4.20
secondary button used on voluntary questions for users to clear answers. Participant noting button, but not necessarily relating it to the question being voluntary - just a way to clear/amend what they've put