Password

[jrbarnes9]

Use this place to discuss the password component in the ONS Design System

[SteveScorfield]

Hello, I have noticed that there is an issue with the “password/_macro.njk”. When calling "onsPassword", I receive the following error:

File "/app/app/templates/signin.html", line 29, in top-level template code
{% set password_input = onsPassword({
File "/usr/local/lib/python3.6/site-packages/jinja2/runtime.py", line 579, in _invoke
rv = self._func(*arguments)
File "/app/app/templates/components/password/_macro.njk", line 7, in template
{% call onsField({
File "/usr/local/lib/python3.6/site-packages/jinja2/runtime.py", line 579, in _invoke
rv = self._func(*arguments)
File "/app/app/templates/components/field/_macro.njk", line 17, in template
{{ caller() }}
File "/usr/local/lib/python3.6/site-packages/jinja2/runtime.py", line 579, in _invoke
rv = self._func(*arguments)
File "/app/app/templates/components/password/_macro.njk", line 32, in template
onsInput({
File "/usr/local/lib/python3.6/site-packages/jinja2/runtime.py", line 579, in _invoke
rv = self._func(*arguments)
File "/app/app/templates/components/input/_macro.njk", line 44, in template
{{ onsLabel({
File "/usr/local/lib/python3.6/site-packages/jinja2/environment.py", line 430, in getattr
return getattr(obj, attribute)
jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'label'

We have managed to fix the issue locally by including the “label” attribute within “onsInput”:

            onsInput({
                "id": params.id,
                "name": params.name,
                "type": "password",
                "classes": "u-mt-xs js-password-input",
                "dontWrap": true
                "label": {
                    "text": params.label.text
                }
            })

This may need adding to future releases.

[jrbarnes9]

#334 raised

[jrbarnes9]

#728 resolved

[LaurenDowling]

This article was shared on the GOV design system backlog: https://www.otto-js.com/news/article/chrome-and-edge-enhanced-spellcheck-features-expose-pii-even-your-passwords

The suggested mitigation is to add spellcheck=false to the input. I can see the MOJ password reveal already has this.