Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Header Component #2740

Closed
willcAND opened this issue Jul 20, 2023 · 0 comments
Closed

Refactor Header Component #2740

willcAND opened this issue Jul 20, 2023 · 0 comments
Labels
Breaking changes This PR contains at least one breaking change Enhancement Change of existing feature

Comments

@willcAND
Copy link
Contributor

willcAND commented Jul 20, 2023

Currently, the header component is overly complex and includes examples such as example-header-external-with-sub-navigation which are using a subNavigation object parameter not documented inside the navigation inside header/_macro-options.md.

Additionally, the header component is allowing for text or title to be passed into the itemsList array for navigation links. This change was made here - #1826 to avoid a Breaking Change. Needs to be updated to title only.

header is also using the navigation component which is not documented on the site, so it should be refactored to use thesection-navigation component instead.

@willcAND willcAND added Enhancement Change of existing feature Breaking changes This PR contains at least one breaking change labels Jul 20, 2023
@daniellecorke daniellecorke closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes This PR contains at least one breaking change Enhancement Change of existing feature
Projects
None yet
Development

No branches or pull requests

4 participants