Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and adjust the spacing on the footer to fit in the new grid #3387

Open
rmccar opened this issue Oct 8, 2024 · 0 comments
Open

Review and adjust the spacing on the footer to fit in the new grid #3387

rmccar opened this issue Oct 8, 2024 · 0 comments
Labels
Enhancement Change of existing feature

Comments

@rmccar
Copy link
Contributor

rmccar commented Oct 8, 2024

_Adjust the padding and margins in the footer so that the icons sit on the grid and the size of them and their container are in whole numbers in terms of pixels.

Also the the margin above the line is now 32px instead of 33px._

As a user,
I want the padding and margins in the footer to be adjusted,
so that the icons sit on the grid and their size, along with their container, are in whole numbers in terms of pixels.

Acceptance Criteria:

  1. Investigate the current padding and margin settings in the footer.
  2. Identify any discrepancies or misalignments with the grid.
  3. Adjust the padding and margin settings to ensure that the icons sit correctly on the grid and their size, along with their container, are in whole numbers in terms of pixels.
  4. Change the margin above the line from 33pix to 32pix.
  5. Verify that the changes are consistent across different screen sizes and devices.
  6. Ensure that the visual appearance of the footer is improved and aligns with the overall design guidelines.

Visualisation
Screenshot 2024-10-08 at 16 17 53

Link to the issue on Figma https://www.figma.com/design/Wr9b6pK35euFoA6xq3G9Ld/Grid-review?node-id=0-1&node-type=canvas&m=dev

@rmccar rmccar added the Enhancement Change of existing feature label Oct 8, 2024
@MagdalenaLarge MagdalenaLarge changed the title Review the spacing on the footer now the new grid has been implemented Review and adjust the spacing on the footer to fit in the new grid Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

No branches or pull requests

1 participant