Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Fix Lighthouse failure - Summary #219

Open
MagdalenaLarge opened this issue Sep 23, 2024 · 1 comment · May be fixed by ONSdigital/design-system#3408
Open

[TASK] Fix Lighthouse failure - Summary #219

MagdalenaLarge opened this issue Sep 23, 2024 · 1 comment · May be fixed by ONSdigital/design-system#3408

Comments

@MagdalenaLarge
Copy link

MagdalenaLarge commented Sep 23, 2024

Alessio addressed Lighthouse failure in the ticket ONSdigital/design-system#3350.

As an outcome of the above ticket, identified a need to address the warnings for all below components. It relates to accessibility.

List of components

1 result(s) for http://localhost:39203/components/summary/example-summary.html
1 result(s) for http://localhost:39203/components/summary/example-summary-no-action.html
1 result(s) for http://localhost:39203/components/summary/example-summary-multiple.html
1 result(s) for http://localhost:39203/components/summary/example-summary-hub.html
1 result(s) for http://localhost:39203/components/summary/example-summary-hub-minimal.html
1 result(s) for http://localhost:39203/components/summary/example-summary-household.html
1 result(s) for http://localhost:39203/components/summary/example-summary-grouped.html
1 result(s) for http://localhost:39203/components/summary/example-summary-grouped-with-errors.html
1 result(s) for http://localhost:39203/components/summary/example-summary-grouped-total.html
1 result(s) for http://localhost:39203/components/summary/example-summary-card-grouped.html

Action
Use yarn start and then move onto the above components in order. Use the lighthouse test from the google chrome dev tools. Run the test on the component and only look at the accessibility score. Fix the issues highlighted under the accessibility section. Run the test again and confirm that they are now at 100. Move on to the next component.

@rmccar
Copy link

rmccar commented Oct 25, 2024

This one seems to be an issue with the elements we have added inside <dl> elements, we have our <dt> and <dd> elements within two divs and then inside a <dl>. It is only valid to have one level of divs between them and the <dl>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants