Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Fix Lighthouse failure - Hub and spoke #224

Open
rmccar opened this issue Oct 28, 2024 · 0 comments · May be fixed by ONSdigital/design-system#3410
Open

[TASK] Fix Lighthouse failure - Hub and spoke #224

rmccar opened this issue Oct 28, 2024 · 0 comments · May be fixed by ONSdigital/design-system#3410

Comments

@rmccar
Copy link

rmccar commented Oct 28, 2024

Alessio addressed Lighthouse failure in the ticket ONSdigital/design-system#3350.

As an outcome of the above ticket, identified a need to address the warnings for all below components. It relates to accessibility.

List of components

1 result(s) for http://localhost:39203/patterns/hub-and-spoke/example-spoke-summary.html
1 result(s) for http://localhost:39203/patterns/hub-and-spoke/example-hub.html
1 result(s) for http://localhost:39203/patterns/hub-and-spoke/example-hub-complete.html

Action
Use yarn start and then move onto the above components in order. Use the lighthouse test from the google chrome dev tools. Run the test on the component and only look at the accessibility score. Fix the issues highlighted under the accessibility section. Run the test again and confirm that they are now at 100. Move on to the next component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant