Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise padding and margins utility class #74

Closed
MagdalenaLarge opened this issue Jul 10, 2024 · 2 comments · Fixed by ONSdigital/design-system#3272
Closed

Standardise padding and margins utility class #74

MagdalenaLarge opened this issue Jul 10, 2024 · 2 comments · Fixed by ONSdigital/design-system#3272
Assignees
Labels

Comments

@MagdalenaLarge
Copy link

MagdalenaLarge commented Jul 10, 2024

As Interaction Designer
I want to have standard padding and margins
So that they sit correctly in 8pix grid on ONS website

Description
As an outcome of change from 9 pix to 8 pix grid, we need to look into standardising utility classes for padding and margins.
This will support new ONS website and give user better experience on both mobile and desktop devices.

Acceptance criteria

  1. All the utility classes for padding and margins have been identified
  2. Utility classes for padding and margins have been standardise
  3. Padding and margins are sitting in the 8pix grid
  4. Padding and margins are correctly adjusted to the device type.

Visualisation/Input from UCD
How should the components look like?

Linked User stories/epics
Issue link to the change of utility classes to 8 pix grid
Technical details

To do this we will need to:

  • change the _pad.scss file to match the configuration of the _margin.scss file. The sizes in the padding file will change to match the sizes in the margin file.
  • !important should be removed from the no size and added to the function below like in the margin doc.
  • also rename _pad.scss to _padding.scss and update all references to it for consistency.

After doing this the visual tests will need to be run and the results reviewed. There will be some instances of utility padding classed being used where the size of the padding will need to change.

MVP (optional)

@MagdalenaLarge MagdalenaLarge added Enhancement Change of existing feature Refine To be refined ONS website labels Jul 10, 2024
@e-livingstone e-livingstone added High Priority and removed Refine To be refined labels Jul 12, 2024
@MagdalenaLarge
Copy link
Author

Screenshot 2024-07-12 at 10 07 26
For the reference please use the Typography prepared by Interaction Designers.

@Majsol
Copy link

Majsol commented Jul 17, 2024

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants