Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-keyword script creates messy diffs #228

Open
blattms opened this issue Apr 8, 2024 · 1 comment
Open

add-keyword script creates messy diffs #228

blattms opened this issue Apr 8, 2024 · 1 comment

Comments

@blattms
Copy link
Member

blattms commented Apr 8, 2024

If I do (my intention was to show how clean the diff of the other files is 😅 ):

$ git reset --hard HEAD
$ fodt-add-keyword --maindir=../parts --keyword=HELLO --section=4.3 --title="Hello World" --status=green

the diff looks a bit messy. Seems like the script changes A.fdot by reintroducing closing tags, e.g.:

-   <config:config-item config:name="PrinterSetup" config:type="base64Binary"/>
+   <config:config-item config:name="PrinterSetup" config:type="base64Binary"></config:config-item>

Not sure where this comes from. I thought we actually changed that.

@hakonhagland
Copy link
Collaborator

Yes I think we have not fixed the add-keyword script to handle empty tags yet. I will try to fix the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants