Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 'MapPanel' object has no attribute 'IsDockable' #3112

Closed
hjaekel opened this issue Aug 4, 2023 · 2 comments · Fixed by #3116
Closed

[Bug] 'MapPanel' object has no attribute 'IsDockable' #3112

hjaekel opened this issue Aug 4, 2023 · 2 comments · Fixed by #3116
Labels
bug Something isn't working GUI wxGUI related
Milestone

Comments

@hjaekel
Copy link

hjaekel commented Aug 4, 2023

Describe the bug
In Grass 8.3.0, when saving the GUI Settings, I get the following Python error:

  File "/usr/lib/grass83/gui/wxpython/gui_core/preferences.py", line 1856, in _updateSettings

if (not mapdisp.IsDockable() or not mapdisp.IsDocked()) and
(
^
AttributeError: 'MapPanel' object has no attribute 'IsDockable'. Did you mean: 'IsFocusable'?

To Reproduce
Steps to reproduce the behavior:

  1. Open Grass
  2. In the menu bar, goto Settings → Preferences
  3. Click Save
  4. See error

Expected behavior
wx.Panel has no property IsDockable, that property is available in AuiPaneInfo.

System description (please complete the following information):

  • Operating System: Alpine Linux Edge
  • GRASS GIS version 8.3.0
GRASS > g.version -rge
version=8.3.0
date=2023
revision=exported
build_date=2023-08-03
build_platform=x86_64-alpine-linux-musl
build_off_t_size=8
libgis_revision=8.3.0
libgis_date=2023-08-03T20:16:12+00:00
proj=9.2.1
gdal=3.7.1
geos=3.12.0
sqlite=3.42.0
~ $ python3 -c "import sys, wx; print(sys.version); print(wx.version())"
3.11.4 (main, Jul 27 2023, 21:07:43) [GCC 13.1.1 20230722]
4.2.0 gtk3 (phoenix) wxWidgets 3.2.2.1

Additional context
The code was introduced with #3024

@hjaekel hjaekel added the bug Something isn't working label Aug 4, 2023
@hjaekel hjaekel changed the title [Bug] [Bug] 'MapPanel' object has no attribute 'IsDockable' Aug 4, 2023
@veroandreo veroandreo added the GUI wxGUI related label Aug 7, 2023
@petrasovaa petrasovaa linked a pull request Aug 8, 2023 that will close this issue
@petrasovaa
Copy link
Contributor

Thanks for reporting the issue. A workaround is to uncheck "Save current window layout as default" in settings, or install development version, which doesn't have this issue.

@petrasovaa petrasovaa added this to the 8.3.1 milestone Aug 8, 2023
@hjaekel
Copy link
Author

hjaekel commented Aug 11, 2023

I tested your patch, the issue is fixed.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants