Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binder: update dependencies #3063

Merged
merged 3 commits into from
Aug 1, 2023
Merged

binder: update dependencies #3063

merged 3 commits into from
Aug 1, 2023

Conversation

neteler
Copy link
Member

@neteler neteler commented Jun 24, 2023

Attempt to update dependencies to fix failing binder sessions.

Attempt to update dependencies to fix failing binder sessions.
@neteler neteler added bug Something isn't working backport to 8.3 labels Jun 24, 2023
@neteler neteler requested a review from wenzeslaus June 24, 2023 22:17
@neteler neteler self-assigned this Jun 24, 2023
@neteler neteler requested review from chaedri and removed request for wenzeslaus June 24, 2023 22:36
@chaedri
Copy link
Contributor

chaedri commented Jun 26, 2023

I tested this in Binder and got the following error:

checking whether to use PDAL... yes
Package geos was not found in the pkg-config search path.
Perhaps you should add the directory containing `geos.pc'
to the PKG_CONFIG_PATH environment variable
Package 'geos', required by 'pdal', not found
configure: error: *** Unable to locate suitable (>=1.7.1) PDAL library.

@neteler
Copy link
Member Author

neteler commented Jun 27, 2023

Thanks for testing. Can you pls check the relevant snippet in config.log to see the real error?

And, would this help (very unusual, though):
export PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig/

@chaedri
Copy link
Contributor

chaedri commented Jun 28, 2023

I'm not sure how to check that in Binder since the terminal is display-only. Here's a link in case anyone wants to test:

https://mybinder.org/v2/gh/neteler/grass/binder_update?labpath=doc%2Fnotebooks%2Fjupyter_example.ipynb

Maybe @wenzeslaus has an idea?

@wenzeslaus
Copy link
Member

Add --without-pdal to the configure. That should build it without PDAL like before and then you can experiment with compilation once the binder is build.

@neteler
Copy link
Member Author

neteler commented Jul 29, 2023

@chaedri Would you mind to give this another try on binder?

@neteler neteler added this to the 8.3.1 milestone Jul 29, 2023
Copy link
Contributor

@chaedri chaedri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting an error when I try it in Binder:

checking whether to use PDAL... yes
Package geos was not found in the pkg-config search path.
Perhaps you should add the directory containing `geos.pc'
to the PKG_CONFIG_PATH environment variable
Package 'geos', required by 'pdal', not found
Package geos was not found in the pkg-config search path.
Perhaps you should add the directory containing `geos.pc'
to the PKG_CONFIG_PATH environment variable
Package 'geos', required by 'pdal', not found
configure: error: *** Unable to locate suitable (>=1.7.1) PDAL library.

Also, you can test it anytime from this url:

https://mybinder.org/v2/gh/neteler/grass/binder_update?labpath=doc%2Fnotebooks%2Fjupyter_example.ipynb

@petrasovaa
Copy link
Contributor

petrasovaa commented Jul 31, 2023

Looks like the PDAL version for 18.04 is too old, so I removed it. However, looks like Binder is upgrading to 22.04 soon, so we will need to revisit this.

@petrasovaa petrasovaa merged commit 3d2a4f1 into OSGeo:main Aug 1, 2023
19 checks passed
@neteler neteler deleted the binder_update branch August 1, 2023 20:33
neteler added a commit that referenced this pull request Aug 1, 2023
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants