Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix os-getcwd (PTH109) by replacing os.getcwd() calls with Path.cwd() #4413

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Sep 28, 2024

Ruff rule: https://docs.astral.sh/ruff/rules/os-getcwd/

When unable to confirm a Path would be accepted, I wrapped Path.cwd() with str(), so the variable would remain a string. When I had to add an import, I placed it such that it tends to what isort would do, but without changing other imports around it.

…h.cwd()

Ruff rule: https://docs.astral.sh/ruff/rules/os-getcwd/

When unable to confirm a Path would be accepted, I wrapped Path.cwd() with str(), so the variable would remain a string.
When I had to add an import, I placed it such that it tends to what isort would do, but without changing other imports around it.
@echoix echoix added this to the 8.5.0 milestone Sep 28, 2024
@github-actions github-actions bot added GUI wxGUI related vector Related to vector data processing raster Related to raster data processing Python Related code is in Python translation Message translation related libraries module labels Sep 28, 2024
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@echoix echoix merged commit ead659f into OSGeo:main Sep 28, 2024
28 checks passed
@echoix echoix deleted the fix-PTH109-os-getcwd branch September 28, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related libraries module Python Related code is in Python raster Related to raster data processing translation Message translation related vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants