Passing unit value as argument to function RS-E1015 major bugrisk

[philipjonsen]

Description
This issue is raised when a unit value is passed to a function call without using the unit literal: (). If this is intentional, extract the argument into a separate expression and replace it with (). Otherwise, consider revisiting this function call.

Bad practice

`fn foo<T: Debug>(t: T) {}

let v = vec![1].extend(&[2, 3]);
foo(v); // v is () here, and not [1, 2, 3]

Recommened:

`fn foo<T: Debug>(t: T) {}

let v = vec![1].extend(&[2, 3]);
foo(v); // v is () here, and not `[1, 2, 3]``

The argument(s) to Ok contain the unit-type
arbitrator/wasm-libraries/user-test/src/program.rs

fn write_slice(&self, ptr: GuestPtr, src: &[u8]) -> Result<(), MemoryBoundsError> {
    self.check_memory_access(ptr, src.len() as u32)?;
    unsafe { Ok(STATIC_MEM.write_slice(ptr, src)) }
}

fn say<D: Display>(&self, text: D) {

The argument(s) to Ok contain the unit-type
arbitrator/wasm-libraries/user-test/src/program.rs

fn write_u32(&mut self, ptr: GuestPtr, x: u32) -> Result<(), MemoryBoundsError> {
    self.check_memory_access(ptr, 4)?;
    unsafe { Ok(STATIC_MEM.write_u32(ptr, x)) }
}

fn write_slice(&self, ptr: GuestPtr, src: &[u8]) -> Result<(), MemoryBoundsError> {

The argument(s) to Ok contain the unit-type
arbitrator/wasm-libraries/user-host/src/program.rs

fn write_slice(&self, ptr: GuestPtr, src: &[u8]) -> Result<(), MemoryBoundsError> {
    self.check_memory_access(ptr, src.len() as u32)?;
    unsafe { Ok(STATIC_MEM.write_slice(ptr, src)) }
}

fn say<D: Display>(&self, text: D) {

The argument(s) to Ok contain the unit-type
arbitrator/wasm-libraries/user-host/src/program.rs

fn write_u32(&mut self, ptr: GuestPtr, x: u32) -> Result<(), MemoryBoundsError> {
    self.check_memory_access(ptr, 4)?;
    unsafe { Ok(STATIC_MEM.write_u32(ptr, x)) }
}

fn write_slice(&self, ptr: GuestPtr, src: &[u8]) -> Result<(), MemoryBoundsError> {

The argument(s) to update contain the unit-type
arbitrator/prover/src/machine.rs

let mut h = Keccak256::new();
h.update("Call indirect:");
h.update((table as u64).to_be_bytes());
h.update(ty.hash());
h.finalize().into()

}

The argument(s) to evm_stack::StackExecutor::new_with_precompiles contain the unit-type
arbitrator/prover/fuzz/fuzz_targets/osp.rs

    StackSubstateMetadata::new(MAX_OSP_GAS, &EVM_CONFIG),
    &*EVM_BACKEND,
);
evm_stack::StackExecutor::new_with_precompiles(stack, &EVM_CONFIG, &())

}

fn test_proof(

[joshuacolvin0]

Linters typically produce a lot of false positive hits, none of this is useful information.