Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background shading behind arrival time cards isn't consistent #451

Closed
barbeau opened this issue Mar 28, 2016 · 4 comments
Closed

Background shading behind arrival time cards isn't consistent #451

barbeau opened this issue Mar 28, 2016 · 4 comments

Comments

@barbeau
Copy link
Member

barbeau commented Mar 28, 2016

Summary:

If you look closely at the background color behind the cards for Arrival info, both Style A and B, there is a darker gray surrounding by a lighter gray - the background should all be the same color (minus the shadow of the card itself).

This seems to be more noticeable when viewing the ArrivalsListFragment within the ArrivalsListActivity than the sliding panel, but exists in both views.

I believe this started showing up when my device (LG G4) updated to Android 6.0.

Steps to reproduce:

For ArrivalsListActivity - star a stop, and then tap on the starred stop from the Starred Stops view. Or, create a home screen shortcut and tap on that shortcut.

For sliding panel - go to Nearby view, and tap on a bus stop and slide the panel up.

Expected behavior:

The color behind the cards should be one shade of gray (minus the shadow from the card itself).

Observed behavior:

There are two shades of gray - a darker one surrounding the card, and lighter one in a square surrounding the darker shade.

Device and Android version:

Stock LG G4 w/ Android 6.0. As mentioned above, I don't believe this occurred on 5.x on the same device.

In OBA project dependencies:

compile 'com.android.support:cardview-v7:22.2.1'
compile 'com.android.support:design:22.2.1'

Screenshots:

image

@barbeau barbeau added the bug label Mar 28, 2016
@barbeau barbeau added this to the v2.1 milestone Mar 28, 2016
@barbeau
Copy link
Member Author

barbeau commented Mar 28, 2016

This is also very noticeable in the ArrivalsListActivity view for stops with no immediate upcoming arrivals:

image

It looks like the fill color within the card itself is off as well.

@barbeau
Copy link
Member Author

barbeau commented May 31, 2016

From a quick look, it seems that this is still a problem with:

compile 'com.android.support:cardview-v7:23.4.0'
compile 'com.android.support:design:23.4.0'

@barbeau barbeau modified the milestones: v2.2, v2.1 Jun 23, 2016
@barbeau barbeau modified the milestones: v2.4, v2.6 Apr 12, 2019
@kungharrison
Copy link
Contributor

kungharrison commented Jan 3, 2024

I think I found the issue, the problem seems to be that there are unique color resources for each list's background with slightly different off-white colors compared to the plain white background (i.e. arrival_list_background is a slight off-white color), and that the background colors are only being applied to the footer's style instead of the entire background. That can be fixed, but is it intentional that all the background color resources used are slightly different colors of white?

image

ArrivalsListActivity view:
image

@aaronbrethorst
Copy link
Member

Fixed in #1102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants