Wrong type definition of OneSignal.postNotification() jsonData parameter

[dmitry-salnikov]

OneSignal Cordova SDK version 3.0.1

The type definition says that notification data is passed as string:

OneSignal-Cordova-SDK/types/OneSignalPlugin.d.ts

Lines 189 to 196 in 5372e15

	/**
	* Send a notification
	* @param {string} notificationObjectString - JSON string payload (see REST API reference)
	* @param {(success:object)=>void} onSuccess
	* @param {(failure:object)=>void} onFailure
	* @returns void
	*/
	postNotification(notificationObjectString: string, onSuccess?: (success: object) => void, onFailure?: (failure: object) => void): void;

However, the iOS native code expects NSDictionary

OneSignal-Cordova-SDK/src/ios/OneSignalPush.m

Lines 307 to 310 in 5372e15

	- (void)postNotification:(CDVInvokedUrlCommand*)command {
	postNotificationCallbackId = command.callbackId;
	[OneSignal postNotification:command.arguments[0]

OneSignal.postNotification definition (OneSignal iOS SDK v3.9.1 as mentioned in release notes of OneSignal Cordova SDK v3.0.1):

https://github.com/OneSignal/OneSignal-iOS-SDK/blob/fd06483b314f842c16e0a6f74dfb27a04dc7df66/iOS_SDK/OneSignalSDK/Source/OneSignal.h#L502-L504

#pragma mark Post Notification
+ (void)postNotification:(NSDictionary* _Nonnull)jsonData;
+ (void)postNotification:(NSDictionary* _Nonnull)jsonData onSuccess:(OSResultSuccessBlock _Nullable)successBlock onFailure:(OSFailureBlock _Nullable)failureBlock;

Could you please fix this type definition?

[nan-li]

Thank you for reporting this @dmitry-salnikov,

We are making some typescript changes and this definition will be fixed.