Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services uses private tags #26

Closed
koenedaele opened this issue Aug 29, 2016 · 0 comments
Closed

Services uses private tags #26

koenedaele opened this issue Aug 29, 2016 · 0 comments
Assignees
@koenedaele
Labels
bug
Milestone
0.3.1

Comments

@koenedaele
Copy link
Member

koenedaele commented Aug 29, 2016 •
edited
Loading

Sometimes the services return private language tags, eg. x-flemish in tgn:7024097.

Currently this is not accepted by language-tags (see OnroerendErfgoed/language-tags#15), causing reading an concept using a private tag to fail. We might need to get a workaround for the moment.
@koenedaele koenedaele added the bug label Aug 29, 2016
@koenedaele koenedaele self-assigned this Aug 29, 2016
@koenedaele koenedaele added this to the 0.3.1 milestone Sep 6, 2016
koenedaele pushed a commit that referenced this issue Sep 6, 2016
Fix for #26.
c3ca799 
When a language tag is invalid, do not drop the label but set the language to
undetermined.
@koenedaele koenedaele mentioned this issue Sep 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koenedaele koenedaele

Labels
bug
Projects
None yet
Milestone
0.3.1
Development

No branches or pull requests
1 participant
@koenedaele