From 3e0c419fe977c822353cff892035f83466327d05 Mon Sep 17 00:00:00 2001 From: owlisnotacat1 <118146757+owlisnotacat1@users.noreply.github.com> Date: Sat, 1 Jul 2023 20:00:22 -0500 Subject: [PATCH] Fix Fanfares Killing Music Bug This fix comments out some useless code in Music.py that changes the cache load type to 2 for all sequences. There is no need to update this data as the cache load type is set correctly already. --- Music.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Music.py b/Music.py index 8ae808656..9de311a5a 100644 --- a/Music.py +++ b/Music.py @@ -440,7 +440,8 @@ def rebuild_sequences(rom: Rom, sequences: list[Sequence], log: CosmeticsLog, sy rom.write_int32(0xB89AE0 + (i * 0x10), new_sequences[i].address) rom.write_int32(0xB89AE0 + (i * 0x10) + 0x04, new_sequences[i].size) seq = replacement_dict.get(i, None) - rom.write_int16(0xB89AE0 + (i * 0x10) + 0x08, seq.type) + #if seq: + # rom.write_int16(0xB89AE0 + (i * 0x10) + 0x08, seq.type) *This breaks fanfares and battle music as this sets the cache load type to 2 for every sequence. There is no need to update this data. # Update instrument sets for i in range(0x6E):