Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting with Blue Fire Arrows #2172

Open
r0bd0g opened this issue Feb 3, 2024 · 2 comments
Open

Starting with Blue Fire Arrows #2172

r0bd0g opened this issue Feb 3, 2024 · 2 comments
Labels
Component: Randomizer Core Generally the core functions of the python Type: Bug Something isn't working

Comments

@r0bd0g
Copy link

r0bd0g commented Feb 3, 2024

RealRob ran into this while working on boulder shuffle.
Apparently you can only start with Ice Arrows, and then they never get turned into Blue Fire Arrows for logic purposes.

@r0bd0g r0bd0g changed the title Starting the Blue Fire Arrows Starting with Blue Fire Arrows Feb 3, 2024
@rrealmuto
Copy link

rrealmuto commented Feb 3, 2024

Specifically, when you start with Ice Arrows, the starting_items collection in the Distribution object does not get updated. Then when building the item pool, Ice Arrows/Blue Fire Arrows are properly removed from the pool, but the call to world.distribution.collect_starters(world.state) collects Ice Arrows instead of Blue Fire Arrows. Thus any logic looking for Blue Fire Arrows will fail because they aren't collected.

@fenhl fenhl added the Type: Bug Something isn't working label Feb 3, 2024
@rrealmuto
Copy link

a simple fix might be to resolve the item name based on the settings prior to the calls to add_starting_item_with_ammo Probably want to do this in both configure_effective_starting_items and in reset in Plandomizer.py

@fenhl fenhl added the Component: Randomizer Core Generally the core functions of the python label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Randomizer Core Generally the core functions of the python Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants