Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python type checks in CI #2177

Open
fenhl opened this issue Feb 15, 2024 · 1 comment
Open

Python type checks in CI #2177

fenhl opened this issue Feb 15, 2024 · 1 comment
Labels
Status: Blocked Waiting for something else to happen first Type: Maintenance Code style, infrastructure, updating dependencies

Comments

@fenhl
Copy link
Collaborator

fenhl commented Feb 15, 2024

Add a CI check that uses something like mypy to validate the type annotations in our Python code, to enforce the static typing and to catch PRs like #2155 introducing bugs in the type annotations.

@fenhl fenhl added Type: Maintenance Code style, infrastructure, updating dependencies Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release labels Feb 15, 2024
@fenhl fenhl removed the Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release label Mar 10, 2024
@fenhl
Copy link
Collaborator Author

fenhl commented Sep 17, 2024

Before we enforce type checks in CI, they need to pass first. So this is blocked on #2193.

@fenhl fenhl added the Status: Blocked Waiting for something else to happen first label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked Waiting for something else to happen first Type: Maintenance Code style, infrastructure, updating dependencies
Projects
None yet
Development

No branches or pull requests

1 participant