Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual hints should not hint locations in precompleted dungeons #2242

Open
Level80Starmie opened this issue Jun 9, 2024 · 1 comment
Open
Labels
Component: Hints related to how we help the player Status: Good First Issue Good for newcomers Type: Bug Something isn't working

Comments

@Level80Starmie
Copy link

This issue was previously worked for Sometimes hints in pulls #2085 and #2097 but doesn't seem to account for dual hints. Tested the same way Fenhl did in the testing for 2097, I've updated the plando to precomplete all 8 dungeons and removed all the OW duals, we still get dual hints. The function starting at 954 in Hints.py looks to be doing the check if the location is precompleted, not sure if dual hints containing two locations rather than one might be causing some issue.

precompleted-dual-test.json
OoT_C57A7_XPTFS1AC93_Spoiler.json

@fenhl fenhl added Type: Bug Something isn't working Component: Hints related to how we help the player labels Jun 9, 2024
@fenhl fenhl added the Status: Good First Issue Good for newcomers label Nov 9, 2024
@fenhl
Copy link
Collaborator

fenhl commented Nov 9, 2024

The fix for this is most likely analogous to the one made for Sometimes hints in #2097.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hints related to how we help the player Status: Good First Issue Good for newcomers Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants