Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with file paths in URL paths (user files) #57

Closed
m-mohr opened this issue Mar 13, 2018 · 5 comments
Closed

Problems with file paths in URL paths (user files) #57

m-mohr opened this issue Mar 13, 2018 · 5 comments

Comments

@m-mohr
Copy link
Member

m-mohr commented Mar 13, 2018

Having the file path of the user files in the URL path seems to be a problem for some software packages, e.g. plumber and browsers. We might need to put the file paths into the query.
See Open-EO/openeo-r-backend#7 for more information.

Remark: RFC 3986 says in 2.3 that dots in URLs should not be encoded. Therefore we should not have specified in the API that dots need to be URL encoded as proposed in the linked issue.

@m-mohr m-mohr added the user management incl. authorization, account management and billing label Mar 13, 2018
@m-mohr m-mohr added this to the v0.3 milestone Mar 26, 2018
@m-mohr m-mohr added file management in discussion and removed user management incl. authorization, account management and billing labels Apr 4, 2018
@m-mohr
Copy link
Member Author

m-mohr commented Apr 20, 2018

I think we shouldn't have workarounds for back-end limitations in the API. Therefore we stick with the current behavior for now.

@m-mohr
Copy link
Member Author

m-mohr commented Jun 6, 2018

Must admin that restify for NodeJS has also problems with slashes in path parameters. What about the other back-ends? We might reconsider putting the path into the query of a URL, but that's not "REST".

@m-mohr
Copy link
Member Author

m-mohr commented Jun 12, 2018

We must specify that all path parameters (user_id, job_id, service_id, process_graph_id) except data_id/product_id and path must not contain slashes.

@m-mohr m-mohr modified the milestones: v0.3, v1.0 Jun 21, 2018
@m-mohr m-mohr modified the milestones: v1.0, v0.3, v0.4 Sep 12, 2018
@m-mohr
Copy link
Member Author

m-mohr commented Dec 6, 2018

Could be solved with #135 - wait for a decision on that issue.

@m-mohr m-mohr modified the milestones: v0.4, v1.0 Dec 6, 2018
@m-mohr
Copy link
Member Author

m-mohr commented Jul 20, 2020

It's an OpenAPI and/or tooling limitation after all, closing until further feedback has arrived.

@m-mohr m-mohr closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant