Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify config getter and override system #265

Open
soxofaan opened this issue Mar 1, 2024 · 0 comments
Open

Simplify config getter and override system #265

soxofaan opened this issue Mar 1, 2024 · 0 comments

Comments

@soxofaan
Copy link
Member

soxofaan commented Mar 1, 2024

This came up while trying to get Open-EO/openeo-geopyspark-driver#701 working:

configs defined in openeo-python-driver's OpenEoBackendConfig and used in openeo-python-driver can not be overriden from e.g. openeo-geopyspark-driver's gps_config_overrides as openeo-python-driver and openeo-geopyspark-driver have separate ConfigGetter instances and config_overrides only overrides one of them.

It probably pays of to simplify the config getter system a bit: just have a single ConfigGetter instance in the application. This implies that e.g. openeo-geopyspark-driver would overwrite the default one of openeo-python-driver.
Related: part of the simplification could also involve eliminating the subclass GpsConfigGetter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant