Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some deprecated or non-described fields are made mandatory in Yang #594

Open
roshan-joyce-fujitsu opened this issue Jul 17, 2024 · 1 comment

Comments

@roshan-joyce-fujitsu
Copy link

Please see https://github.com/Open-Network-Models-and-Interfaces-ONMI/TAPI/blob/v2.5.0/YANG/tapi-topology.yang#L701
Because it says min-elements 1, a data store that enforces Yang rules will mandate that there is at least one validation-mechanism specified in the list in each Link. However, there is no definition of validation-mechanism in RIA.

Please see https://github.com/Open-Network-Models-and-Interfaces-ONMI/TAPI/blob/v2.5.0/YANG/tapi-topology.yang#L528
Because it says min-elements 2, a data store that enforces Yang rules will mandate that there is at least one entry in the transitioned-layer-protocol-name list in each Link, even if it is not representing a tranisitonal-link. Please note that transitional-link concept has been deprecated in the RIA.

I think we need to remove the min-elements constraint from these list definitions.

CC: @amazzini

@amazzini
Copy link
Collaborator

The UML2YANG tool translated 1 to 1 and 1 to 0..1 compositions into "uses" statement, which is essentially mandatory, hence the optionality is lost. This may imply the need of a systematic review, to remove some "min-elements" which contradicts main statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants