Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: build environment configuration #1

Open
GloriousEggroll opened this issue Jan 22, 2024 · 5 comments
Open

TODO: build environment configuration #1

GloriousEggroll opened this issue Jan 22, 2024 · 5 comments

Comments

@GloriousEggroll
Copy link
Member

GloriousEggroll commented Jan 22, 2024

@orowith2os
Copy link

I'd also like to add pre/suffixes for game IDs; if a game doesn't have any pre/sufffix, it can be assumed that using the plain protonfix is fine. Otherwise, if it has a pre/suffix attached, it needs a more specific fix in order to work. This may be useful for platforms on which distributors provide different variants of their games, or different versions.

Which, speaking of, versioning protonfixes seems like a good idea as well. This would be worthy of more discussion.

@crestcere
Copy link

It would be great if we could use it with flatpak. I don't want to deal with 32bit libraries.

@imLinguin
Copy link
Member

@crestcere pressure-vessel is based on bwrap, this essentially provides same behaviour as flatpak

@GloriousEggroll GloriousEggroll changed the title TODO TODO: build environment configuration Jan 24, 2024
@beh-10257
Copy link
Contributor

can wayland driver be enabled by an enviroment variable if this lands

@GloriousEggroll
Copy link
Member Author

can wayland driver be enabled by an enviroment variable if this lands

please stop spam asking about this. we already know it exists, and I already know what is needed. We will add it when Valve adds it. There are good reasons why this is not being rushed on their side.

R1kaB3rN added a commit that referenced this issue Jun 14, 2024
- Currently, winetricks verbs are being applied to the wine prefix by executing the winetricks script as an executable for Proton. For some reason, this results in system calls failing for container binaries such as grep and sed, which are required by winetricks for parsing. Here's an example of grep's coredump:

Stack trace of thread 52329:
#0  0x000070003275383b n/a (/lib/ld-linux-x86-64.so.2 + 0x2183b)
#1  0x000070003274e0f8 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c0f8)
#2  0x000070003274f9be n/a (/lib/ld-linux-x86-64.so.2 + 0x1d9be)
#3  0x000070003274e748 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c748)
ELF object binary architecture: AMD x86-64

While this doesn't appear to impact the application of winetricks verbs to the prefix nor has there been reports of this problem yet, as a precaution, we should set these environment variables from the proton script and replicate protonfixes' execution. As a result, theere should be no more coredumps except from wine64-preloader, which should be normal, and the launcher will only guard against valid winetricks verbs
R1kaB3rN added a commit that referenced this issue Jun 30, 2024
* umu_run: remove winetricks environment variables

- Currently, winetricks verbs are being applied to the wine prefix by executing the winetricks script as an executable for Proton. For some reason, this results in system calls failing for container binaries such as grep and sed, which are required by winetricks for parsing. Here's an example of grep's coredump:

>Stack trace of thread 52329:
>\#0  0x000070003275383b n/a (/lib/ld-linux-x86-64.so.2 + 0x2183b)
>#1  0x000070003274e0f8 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c0f8)
>#2  0x000070003274f9be n/a (/lib/ld-linux-x86-64.so.2 + 0x1d9be)
>#3  0x000070003274e748 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c748)
>ELF object binary architecture: AMD x86-64

While this doesn't appear to impact the application of winetricks verbs to the prefix nor has there been reports of this problem yet, as a precaution, we should set these environment variables from the proton script and replicate protonfixes' execution. As a result, theere should be no more coredumps except from wine64-preloader, which should be normal, and the launcher will only guard against valid winetricks verbs

* umu_test: update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants