Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Required fields in Zapier generator #17093

Closed
chenjr0719 opened this issue Nov 15, 2023 · 2 comments · Fixed by #17115
Closed

[REQ] Required fields in Zapier generator #17093

chenjr0719 opened this issue Nov 15, 2023 · 2 comments · Fixed by #17115

Comments

@chenjr0719
Copy link

Is your feature request related to a problem? Please describe.

The current Zapier generator does not include the required field when generate models. All the fields will be optional now.

Describe the solution you'd like

Including the required field based on the document.

Describe alternatives you've considered

Nope

Additional context

The schema of Pet includes two required fields:

required:
- id
- name

The current zapier model does not follow it:

key: `${keyPrefix}id`,
label: `[${labelPrefix}id]`,
type: 'number',
},
...Category.fields(`${keyPrefix}category`, isInput),
{
key: `${keyPrefix}name`,
label: `[${labelPrefix}name]`,
type: 'string',
},

The field schema of zaiper models:
https://zapier.github.io/zapier-platform-schema/build/schema.html#fieldschema

@wing328
Copy link
Member

wing328 commented Nov 17, 2023

thanks for reporting the issue.

cc @valmoz, @emajo

@emajo
Copy link
Contributor

emajo commented Nov 17, 2023

Thanks, I filed a pr with the fix
PR-17115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants