Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zapier: create a search action predicate #19670

Merged

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Sep 25, 2024

closes #19636

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@a-wallen a-wallen force-pushed the create_actions_predicate branch 3 times, most recently from 2d25661 to e5b4252 Compare September 25, 2024 00:43
@wing328
Copy link
Member

wing328 commented Sep 25, 2024

https://github.com/OpenAPITools/openapi-generator/actions/runs/11024202217/job/30617052744?pr=19670

please update the samples when you've time

let me know if you need help

@a-wallen
Copy link
Contributor Author

Should be good to go here: f7cc3c8

@a-wallen
Copy link
Contributor Author

ping @wing328

@a-wallen
Copy link
Contributor Author

a-wallen commented Oct 1, 2024

cc @valmoz, @emajo

@wing328 wing328 merged commit 241f51c into OpenAPITools:master Oct 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] zapier: add a different predicate to qualify createActions
2 participants