-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to run consecutive games without stopping process #52
Comments
After more testing, I believe this is an issue with the actual bot and not BWAPI4J. |
Thanks to @Jabbo16 for providing more details and testing with his bot with which he is currently experiencing degrading effects when running consecutive games. I'm re-opening this issue for documentation and discussion purposes. BWAPI4J clears three containers before initializing types for consecutive games: BWAPI4J/BWAPI4J/src/main/java/org/openbw/bwapi4j/BW.java Lines 445 to 447 in 53c6633
This may not be enough to get a completely cleared state. In addition, I do not like manually clearing containers to "reset" the state. In my opinion, this is a dubious approach. Since BWAPI4J does not have any static members or singletons, I would like to be able to just create a new I still believe closing both the BW process and Java bot process is the best way to run games. However, it should be decided upon if BWAPI4J will support consecutive games. If yes and there is an evident consecutive game bug with BWAPI4J, the bug should obviously be fixed. If BWAPI4J decides not to support consecutive games, code should be modified to end the process after each game. |
- Helps with Issue OpenBW#52: "Unable to run consecutive games without stopping process" - It would be better to create an entirely new "BW" object instead of manually resetting members.
- Helps with Issue OpenBW#52: "Unable to run consecutive games without stopping process" - It would be better to create an entirely new "BW" object instead of manually resetting members.
The bot will slowly degrade more and more if the bot process is not closed after each game.
The text was updated successfully, but these errors were encountered: