Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "allowableConversionType" lists #175

Open
Agilulfo opened this issue Oct 1, 2024 · 1 comment
Open

Update "allowableConversionType" lists #175

Agilulfo opened this issue Oct 1, 2024 · 1 comment

Comments

@Agilulfo
Copy link

Agilulfo commented Oct 1, 2024

I've noticed that the list of "allowableConversionType" for the sport scales are not aligned.
Scale A might have Scale B as allowed conversion but not Viceversa.
It looks like this was more of an oversight than an intentional result.

I'm assuming that the purpose for this variable was to prevent conversion between bouldering and sport grades. But maybe there is more to it.
Either way maybe there is some potential here for some refactoring and to apply the DRY principle.

@musoke
Copy link
Collaborator

musoke commented Oct 2, 2024

Yes, I agree that there is much room for improvement here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants