You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that the list of "allowableConversionType" for the sport scales are not aligned.
Scale A might have Scale B as allowed conversion but not Viceversa.
It looks like this was more of an oversight than an intentional result.
I'm assuming that the purpose for this variable was to prevent conversion between bouldering and sport grades. But maybe there is more to it.
Either way maybe there is some potential here for some refactoring and to apply the DRY principle.
The text was updated successfully, but these errors were encountered:
I've noticed that the list of "allowableConversionType" for the sport scales are not aligned.
Scale A might have Scale B as allowed conversion but not Viceversa.
It looks like this was more of an oversight than an intentional result.
I'm assuming that the purpose for this variable was to prevent conversion between bouldering and sport grades. But maybe there is more to it.
Either way maybe there is some potential here for some refactoring and to apply the DRY principle.
The text was updated successfully, but these errors were encountered: