Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Add model-factory as a git submodule or subtree of opendrr-api #179

Open
anthonyfok opened this issue Mar 4, 2022 · 1 comment
Open

Comments

@anthonyfok
Copy link
Member

OpenDRR/opendrr-api and OpenDRR/model-factory are inextricably related, and their versions often have to match for the stack build to run successfully and produce correct results.

While we have started to match the release tag in add_data.sh, it may be a good idea to have OpenDRR/model-factory as a git "submodule" or "subtree" of OpenDRR/opendrr-api to make that versioned relationship explicit. This will also facilitate testing on master and topic branches without having to create a temporary test release tag.

It may also be a good idea to include most or all other dependent repos: OpenDRR/boundaries, OpenDRR/CanadaSRM, OpenDRR/earthquake-scenarios, OpenDRR/model-inputs, OpenDRR/openquake-inputs as submodules of OpenDRR/opendrr-api too.

Thanks to HabitSeven for the inspiration where the WordPress theme is included as a submodule, which is also a common practice for Hugo websites. Also, Hugo (https://github.com/gohugoio/hugo) started with including hugoDocs (<https://github.com/gohugoio/hugoDocs) as a submodule for hugoDocs, though eventually switched to subtree.

@jvanulde
Copy link
Contributor

jvanulde commented Mar 4, 2022

Interesting idea @anthonyfok. Perhaps a demo and/explanation on how it might work would be helpful at our next review meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants