Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace .csv in dcat api #224

Open
4 tasks
KarenJewell opened this issue Feb 18, 2023 · 2 comments
Open
4 tasks

Replace .csv in dcat api #224

KarenJewell opened this issue Feb 18, 2023 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@KarenJewell
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, the dcat api script (dcat.py) outputs to a .csv which is then ingested into merge_data.py. This should be converted to a .json output to keep consistent with the rest of the project.

Describe the solution you'd like

  • Change the output of dcat.py to be a .json file
  • Update merge_data.py to ingest the new .json file
  • format code with Black before PR
  • update docs (architecture.md and datapipeline.png)

Describe alternatives you've considered
None

Additional context
Original ticket triggering this change is #163

@thiyagarajan17
Copy link

please assign the issue.. would love to work on it!

@KarenJewell KarenJewell moved this from Backlog to In Progress in Open Data Scotland 2024 Feb 18, 2023
@JackGilmore
Copy link
Member

@thiyagarajan17 I did some work on this to do some bug fixes and had forgotten this issue was assigned to you. I've made a start on it if you've got any comments/feedback?

https://github.com/OpenDataScotland/the_od_bods/tree/jack-dcat-improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

3 participants