Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to prevent duplicated schema entries. #125

Open
jh-RLI opened this issue Apr 12, 2023 · 4 comments
Open

Add tests to prevent duplicated schema entries. #125

jh-RLI opened this issue Apr 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@jh-RLI
Copy link
Contributor

jh-RLI commented Apr 12, 2023

Thank you for finding all the redundancies and little errors! Maybe it's possible to write a test for duplicates in future.

Originally posted by @christian-rli in #117 (comment)

@jh-RLI
Copy link
Contributor Author

jh-RLI commented Apr 12, 2023

@christian-rli can you tell me a bit more about the test you suggested. As far as I understand, the test would look for duplicate entries in schmea.json?

@jh-RLI jh-RLI added the enhancement New feature or request label Apr 12, 2023
@christian-rli
Copy link
Contributor

There isn't more to tell. You just described the suggested test in its entirety :)

@jh-RLI
Copy link
Contributor Author

jh-RLI commented Apr 17, 2023

Ah okay, just any duplocate (like key names). I thought you had an example as I didn't follow the discussion before :)

@christian-rli
Copy link
Contributor

I looked into the commits again. the naming suggested duplicate ("redundant") fields. I seems like there weren't actually any, but it's a useful test to be implemented anyway (and an easy one, in case someone needs to learn how to write tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants