Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more explicit types in the json schema instead of just "string". #146

Open
1 task done
jh-RLI opened this issue Jun 17, 2024 · 1 comment
Open
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@jh-RLI
Copy link
Contributor

jh-RLI commented Jun 17, 2024

Description of the issue

The JSON schema spec allows some build in additional types.

Ideas of solution

Since we are currently doing a rewrite of omi checking sting types against python types is not how we want to do this anymore. Using the tooling around json schema is a better solution.

We need to update the type field for each element in the json schema if the value can be described as something else than "string".

Workflow checklist

@jh-RLI jh-RLI added the enhancement New feature or request label Jun 17, 2024
@jh-RLI jh-RLI self-assigned this Jun 17, 2024
@jh-RLI
Copy link
Contributor Author

jh-RLI commented Jun 17, 2024

FYI
@henhuy @christian-rli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant