Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_DEBUG_x86 MACRO optimization & clarification #33

Closed
lida2003 opened this issue Nov 27, 2024 · 3 comments
Closed

_DEBUG_x86 MACRO optimization & clarification #33

lida2003 opened this issue Nov 27, 2024 · 3 comments

Comments

@lida2003
Copy link
Contributor

I have searched code, and it exists in two places:

May be we can optimze this:

//Uncomment when debugging to have access to the windows below the OSD surface
//#define _DEBUG_x86

#ifdef _DEBUG_x86
forcefullscreen=false;
#endif

@lida2003
Copy link
Contributor Author

lida2003 commented Nov 28, 2024

I think it can be removed @henkwiedig . what do you think?

As we have this option:

msposd/msposd.c

Line 114 in cabc6b8

" -v --verbose Show debug infot\n"

msposd/msposd.c

Lines 1350 to 1353 in cabc6b8

case 'v':
verbose = true;
printf("Verbose mode!");
break;

bool forcefullscreen=true;

if (verbose)
forcefullscreen=false;

PS: I don't have forcefullscreen actions on repo's code.

@lida2003
Copy link
Contributor Author

Please review #34

@henkwiedig
Copy link
Collaborator

closed by #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants