Customer save password

[Axepih]

Hello,

Sorry for my English

Preconditions

OpenMage version 20.10.2
PHP 8.3

In this file

app/code/core/Mage/Customer/Model/Customer/Attribute/Backend/Password.php function beforeSave

public function beforeSave($object)
    {
        $password = trim($object->getPassword());
        $len = Mage::helper('core/string')->strlen($password);
        if ($len) {
            $minPasswordLength = Mage::getModel('customer/customer')->getMinPasswordLength();
            if ($len < $minPasswordLength) {
                Mage::throwException(Mage::helper('customer')->__(
                    'The password must have at least %d characters. Leading or trailing spaces will be ignored.',
                    $minPasswordLength
                ));
            }
            $object->setPasswordHash($object->hashPassword($password));
        }
        return $this;
    }

Would it be possible to add protection to the trim?
Like this maybe

       $password = '';
        if ($object->getPassword() !== null) {
            $password = trim($object->getPassword());
        }

I have a lot of third-party code and I can't say how I got here with this warning. But the change does not appear to have any impact on processes

[kiatng]

I have a lot of third-party code and I can't say how I got here with this warning.

What warning do you get?

[Axepih]

Mage_Eav_Model_Entity_Attribute_Exception: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/app/code/core/Mage/Core/Model/Config.php:1478
Stack trace:
#0 /var/www/html/app/Mage.php(536): Mage_Core_Model_Config->getModelInstance()
#1 /var/www/html/app/code/core/Mage/Eav/Model/Entity/Abstract.php(641): Mage::getModel()
#2 /var/www/html/app/code/core/Mage/Eav/Model/Entity/Abstract.php(1617): Mage_Eav_Model_Entity_Abstract->walkAttributes()
#3 /var/www/html/app/code/core/Mage/Customer/Model/Resource/Customer.php(58): Mage_Eav_Model_Entity_Abstract->_beforeSave()
#4 /var/www/html/app/code/core/Mage/Eav/Model/Entity/Abstract.php(1083): Mage_Customer_Model_Resource_Customer->_beforeSave()
#5 /var/www/html/app/code/core/Mage/Core/Model/Abstract.php(380): Mage_Eav_Model_Entity_Abstract->save()

After is from my third party to save a customer who call Mage_Core_Model_Abstract->save()

[kiatng]

I do not see how we can have null deprecation based on the trace stack.

[sreichel]

Possibly something wrong in module code? How can $modelName be null?

[kiatng]

The null deprecation on password = trim($object->getPassword()); was fixed in PR #2891.

[Axepih]

Thank you, very good indication to check the files and update on this file