Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep Storage Unit compat broken with e.g. pushItemIntoSlot #153

Open
ghost opened this issue Apr 20, 2014 · 6 comments
Open

Deep Storage Unit compat broken with e.g. pushItemIntoSlot #153

ghost opened this issue Apr 20, 2014 · 6 comments
Labels

Comments

@ghost
Copy link

ghost commented Apr 20, 2014

getInventorySize returns 3, however trying to push into slots 0, 1, 2, and 3 fails.

Unless I'm doing something wrong, dsu compatibility is broken.

@nevercast
Copy link
Member

Slots start from 0, So slots 0, 1 and 2 are a total of 3 slots.
Please confirm that you can push in to slot 0 as well as 1 and 2.
Cheers.

@nevercast nevercast added the bug label May 13, 2014
@dmarcuse
Copy link

One of the slots (2 maybe) is output only. The other two are input only and should only accept the type of item already contained within the DSU, or all items if the DSU is empty.

@nevercast
Copy link
Member

This is also a possibility, though does push not return false instead of an error if this is the case ?
It has been far too long since I've experimented with OpenP and things may have changed. Though I do believe the issue is an index one. There are only 3 slots, and it starts from 0. (Unlike Lua that is 1-based)

@ghost
Copy link
Author

ghost commented May 17, 2014

I tried slots 0-3. None worked. Might have been fixed in a newer OP version, but I can't test.

@theoriginalbit
Copy link
Contributor

@nevercast what are you talking about... we do a -- on numbers from Lua, so if they want to access slots 0-2 they need to use the numbers 1-3 in Lua...

@nevercast
Copy link
Member

I had assumed that the methods would use Java convention and we would have a proxy method that would make these adjustments. Following this assumption I also assumed that the API was being used directly, instead of through Lua. Disregard my comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants