Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLAM accepts Github IDs with invalid characters #317

Open
zdw opened this issue Apr 26, 2022 · 0 comments
Open

CLAM accepts Github IDs with invalid characters #317

zdw opened this issue Apr 26, 2022 · 0 comments

Comments

@zdw
Copy link
Contributor

zdw commented Apr 26, 2022

Describe the bug

A user can accidentally add an invalid GitHub ID, such as an email address (with . and @ characters) accidentally.

Per https://github.com/shinnn/github-username-regex the signup page only allows alphanumeric data and hyphens (not at beginning or end), so github ID's should have at least a minimal checked for validity when entered.

To Reproduce

  1. Enter an invalid github ID for a user
  2. CLAM accepts it

Expected behavior

Invalid GitHub ID's are not accepted.

Additional context

User hit the wrong button, entered email address as github ID, and it was accepted, leading to confusion about why CLAM was still rejecting patchsets when the email address was registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant